Post by hermsen on #30 Documentation missing
co♻e: A unittest framework for CODESYS
tickets
(Post)
status: open --> accepted assigned_to: h-hermsen Milestone: v1.1.0.0 --> v1.2.0.0
Last updated: 2021-08-10
Post by i-campbell on #39 Assert_Equals() with STRING(1024) Causes PLC Crash
co♻e: A unittest framework for CODESYS
tickets
(Post)
Truncating is unfair, as an Assert value that differes only after byte 255 will return SUCCESS when it should return NOT_IMPLEMENTED. I would rather cfUnit crash my test PLC than just compare some of it. Changing line 147 and 148 to (* STRING <= STRING(255) *) IF UDINT_TO_INT(Expected.TypeClass) = IBaseLibrary.TypeClass.TYPE_STRING AND (Expected.diSize <= SIZEOF(T_MaxString)) AND (Actual.diSize <= SIZEOF(T_MaxString)) THEN Will cause it to fall through to the "compare byte by byte" stuff at the bottom (from line 213). This is good, but will fall down when comparing strings that have not initialized the bytes after the 0x00 Null terminating character.
Last updated: 2021-08-10
Post by i-campbell on #39 Assert_Equals() with STRING(1024) Causes PLC Crash
co♻e: A unittest framework for CODESYS
tickets
(Post)
TcUnit AssertEquals() still overwrites memory cfUnit RC5 AssertEquals() still overwrites memory Additionally, AssertEquals_WSTRING() and AssertEquals_STRING() happily accept strings over 255 in length, and just ignore any characters after the 255th. This might be obvious to the user though, as the function asks for two STRING(255)s. I have a workaround WstringEquals (FUN) / StringEquals (FUN) with AssertEquals_BOOL here https://forge.codesys.com/u/i-campbell/comparestrings/ci/master/tree/CompareStrings.library So I probably need to learn the TcUnit pull request technique, develop and submit a pull request in TcUnit? or just submit a pull request to cfUnit?
Last updated: 2021-08-10
Post by i-campbell on #39 Assert_Equals() with STRING(1024) Causes PLC Crash
co♻e: A unittest framework for CODESYS
tickets
(Post)
Thoughts for implementing STRING > 255 You already have the IECStringUtils library in the project. So it should be OK to Use: // Will return 0 if STRINGs are equal IECStringUtils.Stu.StrCmpA(Expected.pValue, Actual.pValue); If they are not equal, AssertEquals.IteratorCounter will already hold the Position where they first differ. It may be prudent to log: 'Strings first differ at character: ' TO_STRING(IteratorCounter) And then only LOG ~50 characters before and ~50 characters after the change. Make sure to limit this to within the range of the STRING
Last updated: 2021-08-10
Post by aliazzz on #39 Assert_Equals() with STRING(1024) Causes PLC Crash
co♻e: A unittest framework for CODESYS
tickets
(Post)
On a second thought, adding a test for the stringlength might be a good idea to prevent the runtime from crashing. The idea is to clip off any extra characters beyond 255. This way the assert stays true to its intent without causing larger content to crash the runtime A future Extension possibility would be to add a new assert function to accept WSTRING or lengths beyond 255 chars.
Last updated: 2021-08-10
Post by aliazzz on #39 Assert_Equals() with STRING(1024) Causes PLC Crash
co♻e: A unittest framework for CODESYS
tickets
(Post)
Hi Ian, Would you mind to give an update on the status of this Ticket? Thank you!
Last updated: 2021-08-10
Post by hermsen on #39 Assert_Equals() with STRING(1024) Causes PLC Crash
co♻e: A unittest framework for CODESYS
tickets
(Post)
status: pending --> open assigned_to: i-campbell
Last updated: 2021-08-10
(no subject)
co♻e: A unittest framework for CODESYS
tickets
(Thread)
Last updated: 2021-08-10
Post by i-campbell on #41 Implement support for new SP16 64bits datatype assertions
co♻e: A unittest framework for CODESYS
tickets
(Post)
We can use conditional pragmas to preserve compatibility with older versions.
Last updated: 2021-08-10
Post by hermsen on #41 Implement support for new SP16 64bits datatype assertions
co♻e: A unittest framework for CODESYS
tickets
(Post)
assigned_to: h-hermsen
Last updated: 2021-08-10
Ticket #41: Implement support for new SP16 64bits datatype assertions
co♻e: A unittest framework for CODESYS
tickets
(Ticket)
This ticket serves as a placeholder to implement new SP16 64 bits datatypes assertions.2021-08-10 01:57:37.424000 Ticket #41: Implement support for new SP16 64bits datatype assertions co♻e: A unittest framework for CODESYS counit tickets tickets False /lib/counit/tickets/41/ Ticket Implement support for new SP16 64bits datatype assertions False 1 2020-05-06 20:35:55 41 Implement support for new SP16 64bits datatype assertions open This ticket serves as a placeholder to implement new SP16 64 bits datatypes assertions. False False 0 0 0 41 [FUTURE FEATURE] aliazzz hermsen
Last updated: 2021-08-10
(no subject)
co♻e: A unittest framework for CODESYS
tickets
(Thread)
Last updated: 2021-08-10
Home
notchback
wiki
(WikiPage)
This is the personal project of notchback. This project is created automatically during user registration as an easy place to store personal data that doesn't need its own project such as cloned repositories.
Last updated: 2021-08-10
wiki Discussion
notchback
wiki
(Discussion)
Forum for wiki comments
Last updated: 2021-08-10
blog Discussion
notchback
blog
(Discussion)
Forum for blog comments
Last updated: 2021-08-10
(no subject)
notchback
wiki
(Thread)
Last updated: 2021-08-10
Home
niravparmar
wiki
(WikiPage)
This is the personal project of niravparmar. This project is created automatically during user registration as an easy place to store personal data that doesn't need its own project such as cloned repositories.
Last updated: 2021-08-10
wiki Discussion
niravparmar
wiki
(Discussion)
Forum for wiki comments
Last updated: 2021-08-10
blog Discussion
niravparmar
blog
(Discussion)
Forum for blog comments
Last updated: 2021-08-10
(no subject)
niravparmar
wiki
(Thread)
Last updated: 2021-08-10
tickets Discussion
co⚡e: Sparkplug™ MQTT edge and host
tickets
(Discussion)
Forum for tickets comments
Last updated: 2021-08-10
Post by i-campbell on Ticket #57: EoN / Metrics: The final Metric of the example project is not showing up in ignition discussion
co⚡e: Sparkplug™ MQTT edge and host
tickets
(Post)
solved with r376
Last updated: 2021-08-10
Post by hermsen on Ticket #37: FB_MQTTPUBSUB : Before sending a payload, ensure that MQTT.MQTTParam.g_udiMaxPayloadSize and g_udiMaxPacketSize are appropriately set discussion
co⚡e: Sparkplug™ MQTT edge and host
tickets
(Post)
status: open --> accepted
Last updated: 2021-08-10
Post by i-campbell on Ticket #28: FB_Payload.ClaimNextFree* should initialize for you discussion
co⚡e: Sparkplug™ MQTT edge and host
tickets
(Post)
Status: open --> accepted
Last updated: 2021-08-10
Post by i-campbell on Ticket #26: LibCat.xml discussion
co⚡e: Sparkplug™ MQTT edge and host
tickets
(Post)
Same as MQTT Client SL and OSCAT Network? Application.Utils
Last updated: 2021-08-10