Attached a tentative solution for the problem, patch for the FB_AssertResultStatic.ReportResult method, based on what's implemented in FB_AssertArrayResultStatic.ReportResult.
Hi, first off let me start by thanking you for using our unit testing framework solution. As you might know allready this software is an official fork of TcUnit. Therefore, we try to follow the original TcUnit codebase as close as possible or technically permitted. For instance, ADS will not work without a proper implementation in CODESYS, but a bespoke CI/CD runner is not necessary like in TwinCAT3. So there are pro's and con's.
Currently we are waiting for the release of TcUnit v1.3 (or V2?). When it is officially released, you can be sure we will adopt the majority of that codebase into coUnit and hopefully that will plug the majority of the bugs. Since you have found an issue and have proposed a solution I will gladly integrate it into our framework. Just be aware that if a new TcUnit version is released, the proposed fix will be overwritten which might might undo your temporary fix. However with a little luck the original issue is mitigated in the TcUnit source. Sure porting the framwork is fun but it is also a very time consuming and complex task.
With kind regards
the co5e.org team
ps if you are interested, we could add you to the development team so you can contribute if you like. Anybody who wants to contribute is welcome!
👍
1
Last edit: hermsen 2022-05-18
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Attached a tentative solution for the problem, patch for the FB_AssertResultStatic.ReportResult method, based on what's implemented in FB_AssertArrayResultStatic.ReportResult.
Hi, first off let me start by thanking you for using our unit testing framework solution. As you might know allready this software is an official fork of TcUnit. Therefore, we try to follow the original TcUnit codebase as close as possible or technically permitted. For instance, ADS will not work without a proper implementation in CODESYS, but a bespoke CI/CD runner is not necessary like in TwinCAT3. So there are pro's and con's.
Currently we are waiting for the release of TcUnit v1.3 (or V2?). When it is officially released, you can be sure we will adopt the majority of that codebase into coUnit and hopefully that will plug the majority of the bugs. Since you have found an issue and have proposed a solution I will gladly integrate it into our framework. Just be aware that if a new TcUnit version is released, the proposed fix will be overwritten which might might undo your temporary fix. However with a little luck the original issue is mitigated in the TcUnit source. Sure porting the framwork is fun but it is also a very time consuming and complex task.
With kind regards
the co5e.org team
ps if you are interested, we could add you to the development team so you can contribute if you like. Anybody who wants to contribute is welcome!
Last edit: hermsen 2022-05-18