#62 Sparkplug Birth Death Sequence: Should it MOD 256?

1.0.0.0: EoN
wont-fix
nobody
None
2020-10-02
2020-10-02
i-campbell
No

I cannot see in the spec that it says we must limit bdSeq to 255 (and start over from 0).
Currently the code does do MOD 256 at FB_SparkplugBSimple.GetBDSeqNum line 3.
1. confirm if bdseq should be MOD 256, perhaps look at java sample code.
2. if not, correct the code so it counts up to MAX_ULINT

Discussion

  • i-campbell

    i-campbell - 2020-10-02

    according to the Java example, it does do MOD 256.
    So, we will leave the code as is.

     

  • i-campbell

    i-campbell - 2020-10-02
    • status: open --> closed
     

  • i-campbell

    i-campbell - 2020-10-02
    • status: closed --> open
     

  • i-campbell

    i-campbell - 2020-10-02
    • status: open --> wont-fix
     

  • aliazzz

    aliazzz - 2020-10-02

    Reflecting on this ticket:
    The spec only explains the seqnum counting.
    Ps, I implemented BDSeq according to the python example (= MOD 256)

     

Log in to post a comment.